devshort

private self-hosted shortlink service
git clone https://git.clttr.info/devshort.git
Log (Feed) | Files | Refs (Tags) | README | LICENSE

commit c5ed48151bbbdf7efa6f6ac937721e08b5b24dbb
parent c57058c77a97967600393ed572316836c07ae330
Author: René Wagner <rwagner@rw-net.de>
Date:   Mon, 13 Jan 2020 20:05:52 +0100

fix access_count for redirects (#2)

Currently the access counter does only work for "Index.php". This is due to the fact that the variables $stats_content and $stats_path where defined outside of the function scope. In `count_access` $stats_path was <not defined> and the file has never been written.
Diffstat:
Mredirect.php | 8+++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/redirect.php b/redirect.php @@ -16,21 +16,23 @@ $stats_path = implode(DIRECTORY_SEPARATOR, array(__DIR__, "data", "stats.json")) $stats_content = json_decode(file_get_contents($stats_path), true); // Count the access to the given $name -function count_access($base_path, $name) { +function count_access($name) { + global $stats_path, $stats_content; + $stats_content[$name][mktime(0, 0, 0)] += 1; file_put_contents($stats_path, json_encode($stats_content)); } if (array_key_exists($short, $config_content["shortlinks"])) { header("Location: " . $config_content["shortlinks"][$short], $http_response_code=303); - count_access($base_path, $short); + count_access($short); exit; } else if ($short === "") { header("Location: index.php", $http_response_code=301); exit; } else { header("HTTP/1.1 404 Not Found"); - count_access($base_path, "404-request"); + count_access("404-request"); // Generate custom buttons for the footer $links_string = "";